Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wren-ai-service): improve text2chart and text2answer #1016

Merged
merged 7 commits into from
Dec 19, 2024
Merged

chore(wren-ai-service): improve text2chart and text2answer #1016

merged 7 commits into from
Dec 19, 2024

Conversation

cyyeh
Copy link
Member

@cyyeh cyyeh commented Dec 18, 2024 •
edited
Loading

  • text2chart:
    • fix schema JSON decode issue
  • text2answer:
    • remove reasoning process
    • remove technical jargon like SQL syntax
    • refine prompt wording

@cyyeh cyyeh added module/ai-service ai-service related ci/ai-service ai-service related labels Dec 18, 2024
@cyyeh cyyeh marked this pull request as ready for review December 19, 2024 01:13
@cyyeh cyyeh requested a review from paopa December 19, 2024 01:13
paopa
paopa approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paopa paopa merged commit 5df4d03 into main Dec 19, 2024
11 checks passed
@paopa paopa deleted the chore/ai-service/improve-oss-13-release branch December 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paopa paopa paopa approved these changes

Assignees
No one assigned
Labels
ci/ai-service ai-service related module/ai-service ai-service related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyeh @paopa