Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: create a framework for testing functions #927

Merged
merged 7 commits into from
Nov 29, 2024
Merged

test: create a framework for testing functions #927

merged 7 commits into from
Nov 29, 2024

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Nov 20, 2024 •
edited
Loading

@github-actions github-actions bot added ibis dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 20, 2024
@grieve54706 grieve54706 added this to the 0.12.1 milestone Nov 20, 2024
@grieve54706 grieve54706 removed this from the 0.12.1 milestone Nov 21, 2024
@grieve54706 grieve54706 marked this pull request as ready for review November 29, 2024 02:53
@grieve54706 grieve54706 added this to the 0.12.3 milestone Nov 29, 2024
goldmedal
goldmedal approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 It looks good to me.

@goldmedal goldmedal merged commit 82f0c69 into main Nov 29, 2024
9 checks passed
@goldmedal goldmedal deleted the test/all-functions branch November 29, 2024 06:36
grieve54706 added a commit that referenced this pull request Dec 13, 2024
@grieve54706 @goldmedal
test: create a framework for testing functions (#927)
969c0f5 
Co-authored-by: Jax Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
bigquery dependencies Pull requests that update a dependency file ibis python Pull requests that update Python code
Projects
None yet
Milestone
0.12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@grieve54706 @goldmedal