Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcegen CLib edge cases #1846

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Feb 3, 2025

Changes proposed in this pull request

Address several edge cases encountered in CLib

  • Extend auto-generation of CLib APIs to variables (not just functions)
  • Use ReactionPathDiagram as an example (also, C++ API is updated to match Python API)
  • Expose Cantera constants to CLib
  • Implement CLib loggers

If applicable, fill in the issue number this pull request is fixing

Addresses Cantera/enhancements#220

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added the clib label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.39%. Comparing base (e6f3e9d) to head (bb81255).

Files with missing lines Patch % Lines
src/kinetics/ReactionPath.cpp 59.45% 12 Missing and 3 partials ⚠️
interfaces/cython/cantera/reactionpath.pyx 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   74.41%   74.39%   -0.02%     
==========================================
  Files         386      386              
  Lines       53628    53649      +21     
  Branches     9063     9069       +6     
==========================================
+ Hits        39905    39913       +8     
- Misses      10652    10662      +10     
- Partials     3071     3074       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischoegl ischoegl force-pushed the sourcegen-clib-edge branch 2 times, most recently from 3a2e8ec to 1597b38 Compare February 3, 2025 20:25
@ischoegl ischoegl marked this pull request as ready for review February 3, 2025 20:51
@ischoegl ischoegl requested a review from a team February 3, 2025 20:51
@ischoegl ischoegl force-pushed the sourcegen-clib-edge branch from 1597b38 to dfec1b3 Compare February 3, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant