Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zerod connector nodes #1848

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Feb 4, 2025

Changes proposed in this pull request

This PR pulls out the less controversial modifications from #1788, while improving the nomenclature (see Cantera/enhancements#213 (comment)):

  • Create a new ConnectorNode base, which combine Wall and FlowDevice objects; all objects are captured in updated factories.
  • Changes are propagated to all relevant API’s, i.e. Python, CLib and MATLAB.

If applicable, fill in the issue number this pull request is fixing

Addresses Cantera/enhancements#213

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 56.68790% with 68 lines in your changes missing coverage. Please review.

Project coverage is 74.35%. Comparing base (e6f3e9d) to head (eefe4ca).

Files with missing lines Patch % Lines
src/clib/ctreactor.cpp 13.95% 37 Missing ⚠️
src/zeroD/ConnectorFactory.cpp 58.82% 14 Missing ⚠️
interfaces/cython/cantera/reactor.pyx 85.18% 4 Missing ⚠️
src/zeroD/FlowDevice.cpp 86.36% 3 Missing ⚠️
src/zeroD/Wall.cpp 66.66% 3 Missing ⚠️
include/cantera/zeroD/ConnectorNode.h 80.00% 2 Missing ⚠️
src/zeroD/ReactorBase.cpp 0.00% 1 Missing and 1 partial ⚠️
include/cantera/zeroD/FlowDevice.h 0.00% 1 Missing ⚠️
include/cantera/zeroD/Wall.h 0.00% 1 Missing ⚠️
src/zeroD/ConnectorNode.cpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   74.41%   74.35%   -0.06%     
==========================================
  Files         386      387       +1     
  Lines       53628    53626       -2     
  Branches     9063     9066       +3     
==========================================
- Hits        39905    39876      -29     
- Misses      10652    10682      +30     
+ Partials     3071     3068       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant