Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve TODOs #961

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −8
Open

chore: resolve TODOs #961

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b089a6
chore: resolve TODOs
WcaleNieWolny Jan 5, 2025
1f3bce0
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 5, 2025
baac6d1
Merge branch 'main' into fix_todos
riderx Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/tables/BundleTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ async function deleteOne(one: Element) {
}

try {
// todo: fix this for AB testing
const { data: channelFound, error: errorChannel } = await supabase
.from('channels')
.select('name, version(name)')
Expand Down
1 change: 0 additions & 1 deletion src/pages/app/p/[p]/settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ async function setDefaultChannel() {
}

const isSuperAdmin = computed(() => {
// TODO: check if that is smart to not let admins delete apps
if (!role.value)
return false
return organizationStore.hasPermisisonsInRole(role.value as any, ['super_admin'])
Expand Down
1 change: 0 additions & 1 deletion src/pages/dashboard/settings/organization/General.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ async function saveChanges(form: { orgName: string, email: string }) {
.eq('id', gid)

if (error) {
// TODO: INFORM USER THAT HE IS NOT ORG OWNER
console.log(`Cannot save changes: ${error}`)

// Revert the optimistic update
Expand Down
10 changes: 5 additions & 5 deletions supabase/functions/_backend/utils/stripe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ export async function createCheckout(c: Context, customerId: string, reccurence:
name: 'auto',
},
tax_id_collection: { enabled: true },
// TODO: find why this is not working as expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tested it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WcaleNieWolny

// saved_payment_method_options: {
// allow_redisplay_filters: 'always',
// payment_method_save: true,
// },
saved_payment_method_options: {
allow_redisplay_filters: ['always'],
payment_method_save: true,
},

line_items: [
{
price: prices.priceId,
Expand Down
Loading