-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an API endpoint that returns all patterns covering a given address #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the idea and the contribution.
I can help with the documentation / specifications updates. We'll also need to cover the new additions with unit & property tests when applicable.
KtorZ
reviewed
Jul 13, 2022
This allows to test more thoroughly the behavior of the http application, by reaching path that we couldn't otherwise. Note that this also caught a bug in the existing 'deletePattern' endpoint (which would _always_ prevent deletion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the endpoint
/v1/patterns/{pattern-frac}
It returns all patterns that completely cover
{pattern-frac}
(i.e. if the result is non-empty, the user can be sure that{pattern-frac}
UTxOs are correctly represented in the DB - this excludes the possibility of dynamically added patterns)TODO:
Fixes #40 and #38 (?)
Possible alternatives:
{pattern-frac}
and might be concerned about its completeness