e2e-tests reward points #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejzelaszczyk
approved these changes
Jun 29, 2022
…s of reward-points
…ards-block-counts-PR
pmikolajczyk41
requested changes
Jun 30, 2022
There was a problem hiding this comment.
generally great work, kudos! I left some minor comments/requests
btw, after my recent adventures with substrate, I would use word disable with respect and care; thus I strongly encourage you to rename all disable_xxx / enable_xxx methods/tests to something else: your scenario is about invalid key, it doesn't have anything in common with canonical disabling
…able - not waiting 2 additional sessions
pmikolajczyk41
approved these changes
Jul 1, 2022
Refactored. |
fixxxedpoint
force-pushed
the
A0-987-e2e-points-rewards-block-counts-PR
branch
2 times, most recently
from
14b5542 to
461c40e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
disable nodee2e-test for reward points: it attempts to temporarily disable and the re-enable a node and checks if reward points are calculated correctly