Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write CI to protect app_name #2118

Open
TheLastProject opened this issue Oct 16, 2024 · 5 comments
Open

Write CI to protect app_name #2118

TheLastProject opened this issue Oct 16, 2024 · 5 comments
Assignees
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

app_name shouldn't be translated in most languages and should be kept consistent with title.txt.

Write a small shell script or something for GitHub Actions to ensure they're consistent and to block it from being anything except "Catima" except in a list of languages explicitly on an allowlist.

@TheLastProject TheLastProject added type: enhancement New feature or request good first issue Good for newcomers severity: tolerable Low/no impact on users common: uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 16, 2024
@DNotNice
Copy link

Hi @TheLastProject ,
I would like to work on this issue. A basic script for GA would be perfect. Please assign me the issue if no one else is working on it.
Thanks!

@TheLastProject
Copy link
Member Author

Sure, go for it :)

It might be good to look at or possibly extend https://github.com/CatimaLoyalty/Android/blob/main/.scripts/generate_feature_graphic/generate_feature_graphic.sh as that file already reads title.txt, so you're halfway there in comparing it with app_name in the values directories. But take whatever direction you think works best :)

@TheLastProject
Copy link
Member Author

(Actually, that script doesn't run on MRs so it's not sufficient for checking. But parts could maybe be re-used, who knows :))

@DNotNice
Copy link

Hi @TheLastProject ,
I am reading values from title.txt and comparing it with app_name. I just want to confirm if the languages on the allowlist are the ones listed in locale_values inside settings.xml, or if they are mentioned somewhere else.

@TheLastProject
Copy link
Member Author

There's no real allowlist yet as I don't quite know in which languages it is normal to translate the name of the app/trademark, there are just too many languages out there :)

I think to keep it simple let's just say every language that already translated the app name is allowed, so any new ones will fail the CI (and I'll reach out to those translators to make sure or revert until sure) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants