[ENG-2435] Upgrade pytest and others to fix broken tests #9551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
update-testmon
branch
4 times, most recently
from
17677b4 to
dfa0d35
Compare
Johnetordoff
force-pushed
the
update-testmon
branch
from
dfa0d35 to
d936a6d
Compare
Johnetordoff
force-pushed
the
update-testmon
branch
from
266fe52 to
0ce6b5b
Compare
Johnetordoff
force-pushed
the
update-testmon
branch
3 times, most recently
from
bf60095 to
5ce53cf
Compare
Johnetordoff
force-pushed
the
update-testmon
branch
from
5ce53cf to
0ceed2a
Compare
added 4 commits
November 30, 2020 15:16
Johnetordoff
changed the title
jwalz
reviewed
Dec 17, 2020
| @pytest.mark.parametrize('sanction_fixture', [registration_approval, embargo, retraction]) | ||
| def test_approve_after_reject_fails(self, sanction_fixture): | ||
| @pytest.mark.parametrize('sanction_object', [registration_approval, embargo, retraction]) | ||
| def test_approve_after_reject_fails(self, sanction_object): | ||
| # using fixtures in parametrize returns the function |
There was a problem hiding this comment.
nit: This comment is now unnecessary/misleading (in all locations)
|
Can you explain in the description why updating pytest fixed the test linked in the ticket? Also, more detail on what, specifically, pytest doesn't like about these fixtures now (seemingly it doesn't support using fixtures that aren't fully evaluated in test setup, a la via parametrize). |
Johnetordoff
force-pushed
the
update-testmon
branch
from
bb4c9d3 to
3ba26e7
Compare
|
@jwalz ok I made some comments in the description |
Johnetordoff
force-pushed
the
update-testmon
branch
from
3ba26e7 to
d8f706b
Compare
Johnetordoff
force-pushed
the
update-testmon
branch
from
d8f706b to
2252890
Compare
jwalz
reviewed
Jan 12, 2021
| @@ -135,7 +135,6 @@ def test_rejection_flow(self, sanction_object, initial_state, end_state): | |||
|
|
|||
| @pytest.mark.parametrize('sanction_object', [registration_approval, embargo, retraction]) | |||
| def test_approve_after_reject_fails(self, sanction_object): | |||
| # using fixtures in parametrize returns the function | |||
There was a problem hiding this comment.
It's not a huge deal, but if you could go through the file and delete all iterations of this comment, that would be appreciated
jwalz
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a booster shot of updated decencies for the OSF for pytest, these such keep us more up to date with the current test infrastructure and hopefully fix some probabilistic test fails.
You can read about the bug here which indicates updating pytest will fix the issue. I picked pytest 5.0.0 because it is recent and only requires few changes. The biggest change is pytest no long allows passing of fixtures the same way. Read about it here. So that had to be changed to release this.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-2435