Add spec and readme example for using compression with optimizeGlb #48
Conversation
tools/specs/lib/optimizeGlbSpec.js
Outdated
| @@ -24,6 +24,37 @@ describe('optimizeGlb', function() { | |||
| }), done).toResolve(); | |||
| }); | |||
|
|
|||
| it('optimizes and compresses a glb using the gltf-pipeline', function(done) { | |||
| var compressionOptions = { aoOptions: undefined, | |||
There was a problem hiding this comment.
Put aoOptions on a new line.
|
Thanks @shehzan10! @lilleyse please merge when ready. |
|
Requested change fixed. Thanks for reviewing! |
tools/README.md
Outdated
| node ./bin/3d-tiles-tools.js optimizeB3dm -i ./specs/data/Textures/batchedTextured.b3dm -o ./output/optimized.b3dm --options --texcomp.dxt1.enable --texcomp.dxt1.quality=5 --texcomp.etc1.enable | ||
| ``` | ||
| This example optimizes the b3dm and compresses the textures into `dxt1` and `etc1` formats. | ||
|
|
There was a problem hiding this comment.
Place this example after the other examples above. This part of the description is not needed: from [gltf-pipeline](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/master/README.md) under the --options flag. since it should be clear from the first example.
There was a problem hiding this comment.
Same comments for optimizeI3dm
There was a problem hiding this comment.
batchedTextured.b3dm and instancedTextured.i3dm should be included in this PR if they are used as examples.
There was a problem hiding this comment.
Instead of adding these samples to the repo, can we use any textured models are already a part of it? I can update the readme to point to those files.
There was a problem hiding this comment.
I didn't know we had any textured b3dm/i3dm, but yes point to those if they already exist.
tools/README.md
Outdated
| ``` | ||
| node ./bin/3d-tiles-tools.js optimizeI3dm -i ./specs/data/Textured/instancedTextured.i3dm -o ./output/optimized.i3dm --options --texcomp.dxt1.enable --texcomp.dxt1.quality=5 --texcomp.etc1.enable | ||
| ``` | ||
| This example optimizes the b3dm and compresses the textures into `dxt1` and `etc1` formats. |
tools/specs/lib/optimizeGlbSpec.js
Outdated
| @@ -24,6 +24,38 @@ describe('optimizeGlb', function() { | |||
| }), done).toResolve(); | |||
| }); | |||
|
|
|||
| it('optimizes and compresses a glb using the gltf-pipeline', function(done) { | |||
There was a problem hiding this comment.
This description is a bit vague. Just compresses textures in a glb using the gltf-pipeline is fine.
tools/specs/lib/optimizeGlbSpec.js
Outdated
| quantize: false, | ||
| removeNormals: false, | ||
| textureCompressionOptions: [ { quality: 10, format: 'dxt1' } ] | ||
| }; |
There was a problem hiding this comment.
These options are overkill, just add what's needed.
tools/README.md
Outdated
| To use tileset texture compression, pass the [`texcomp` flags](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/master/README.md#command-line-flags) | ||
| from [gltf-pipeline](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/master/README.md) under the `--options` flag. | ||
| ``` | ||
| node ./bin/3d-tiles-tools.js optimizeB3dm -i ./specs/data/Textures/batchedTextured.b3dm -o ./output/optimized.b3dm --options --texcomp.dxt1.enable --texcomp.dxt1.quality=5 --texcomp.etc1.enable |
|
Updated to gltf-pipeline 0.1.0-alpha11 and made a quick fix to call |
gltf-pipelineoptions to the tools command line.Requires minimum CesiumGS/gltf-pipeline#204 to be used in package.json. So the specs might fail in CI.
Fixes #44