-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instanced 3D Model spec #34
Conversation
|
|
||
The `instances` field immediately follows the `glTF` field (which may be omitted when `header.glTFLength` is `0`). | ||
|
||
The `instances` field contains `header.instancesLength` tightly packed instances. Each instance has three fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a word missing here? I couldn't make sense of "contains header.instancesLength
tightly packed instances"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A word is not missing. That should read as "the instances field contains x tightly packed instances" where the value of "x" is defined by header.instancesLength
.
If you think we could make it more clear, please have at it.
If experience proves otherwise, we can make this
Yes, I will make the rename for b3dm and i3dm in this branch. |
Sorry, I mean the length of the arrays in the batch table, not the size of the JSON string in bytes. |
Also, please make these same renames throughout the Cesium implementation.
|
@pjcozzi I'm done. |
The layout image still has |
Good catch, @lilleyse. Updated. |
Merged. |
Fixes #23
@slchow please copyedit. The new writing is in
TileFormats/Instanced3DModel/README.md
. Note that most of this PR is the same changes as #31.@lilleyse please do a technical review. Does the Cesium client handle the corner cases for when, for example,
instancesLength
orbatchTableLength
is zero?@lilleyse merge #31 first.
Before we declare 1.0, there's a few things to address in #33