Skip to content

Commit

Permalink
fix comment and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nithinp7 committed Sep 3, 2021
1 parent 0f222d6 commit b5f8784
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Cesium3DTilesSelection/src/Tile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,10 @@ void Tile::update(
std::move(this->_pContent->pNewTileContext));
}

// If this tile has no model, set its geometric error very high so we
// refine past it. Note that "no" model is different from having a model,
// but it is blank. In the latter case, we'll happily render nothing in
// the space of this tile, which is sometimes useful.
// If this tile has no model, we want to unconditionally refine past it.
// Note that "no" model is different from having a model, but it is blank.
// In the latter case, we'll happily render nothing in the space of this
// tile, which is sometimes useful.
if (!this->_pContent->model) {
this->setUnconditionallyRefine(true);
}
Expand Down
5 changes: 2 additions & 3 deletions Cesium3DTilesSelection/test/TestTilesetSelectionAlgorithm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -628,9 +628,8 @@ TEST_CASE("Test additive refinement") {
"tileset3/tileset3.json") {
REQUIRE(doesTileMeetSSE(viewState, child, tileset));
} else {
// external tileset has always geometric error over 999999, so it
// won't meet sse
REQUIRE(!doesTileMeetSSE(viewState, child, tileset));
// external tilesets get unconditionally refined
REQUIRE(root->getUnconditionallyRefine());

// expect the children to meet sse and begin loading the content
REQUIRE(child.getChildren().size() == 1);
Expand Down

0 comments on commit b5f8784

Please sign in to comment.