Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @brief when schema is missing description #367

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fix @brief when schema is missing description #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CesiumGltf/include/CesiumGltf/KHR_draco_mesh_compression.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace CesiumGltf {
/**
* @brief undefined
* @brief KHR_draco_mesh_compression extension
*/
struct CESIUMGLTF_API KHR_draco_mesh_compression final
: public ExtensibleObject {
Expand Down
2 changes: 1 addition & 1 deletion CesiumGltf/include/CesiumGltf/MaterialNormalTextureInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace CesiumGltf {
/**
* @brief undefined
* @brief Material Normal Texture Info
*/
struct CESIUMGLTF_API MaterialNormalTextureInfo final : public TextureInfo {
static inline constexpr const char* TypeName = "MaterialNormalTextureInfo";
Expand Down
2 changes: 1 addition & 1 deletion CesiumGltf/include/CesiumGltf/MaterialOcclusionTextureInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace CesiumGltf {
/**
* @brief undefined
* @brief Material Occlusion Texture Info
*/
struct CESIUMGLTF_API MaterialOcclusionTextureInfo final : public TextureInfo {
static inline constexpr const char* TypeName = "MaterialOcclusionTextureInfo";
Expand Down
2 changes: 1 addition & 1 deletion tools/generate-gltf-classes/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function generate(options, schema) {

namespace ${namespace} {
/**
* @brief ${schema.description}
* @brief ${schema.description ? schema.description : schema.title}
*/
struct ${namespace.toUpperCase()}_API ${name}${thisConfig.toBeInherited ? "Spec" : (thisConfig.isBaseClass ? "" : " final")} : public ${base} {
static inline constexpr const char* TypeName = "${name}";
Expand Down