Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frustum-like artifacts when using OIT #2327

Closed
mramato opened this issue Dec 16, 2014 · 5 comments
Closed

Frustum-like artifacts when using OIT #2327

mramato opened this issue Dec 16, 2014 · 5 comments
Labels
type - bug

Comments

@mramato
Copy link
Contributor

mramato commented Dec 16, 2014

Load the GeoJSON example and zoom in with the right mouse button. On a machine with OIT enabled (and only certain graphics cards, I have an Nvidia 650TI) you will see a large frustum-like artifact as you approach the surface. Whether it's a frustum problem or not, I don't know. This issue has been there a long time; but it doesn't look like we ever wrote it up.

image
@mramato
Copy link
Contributor Author

mramato commented Dec 16, 2014

I just noticed that only the polygon is affected by this, the lines are drawn correctly. Not sure if that helps narrow down the issue or not.

@emackey
Copy link
Contributor

emackey commented Dec 18, 2014

I think I've seen this on ellipsoids as well.

@mramato
Copy link
Contributor Author

mramato commented Jan 29, 2015

Me and @bagnell have discovered discovered this is an issue with the weighting function in czm_alphaWeight. He's going to experiment with the different weighting functions and it should hopefully fix this issue.

mramato added a commit that referenced this issue Jan 29, 2015
@mramato
Fix OIT on machines where it was broken.
ec973ec 
As pointed out by one of the Chromium developers, we were using an undefined
variable in `czm_alphaWeight` due to a double declaration of the `z` variable
resuling in scoping issues.  This change then lead to another issue that
where textured were black, which was fixed by flipping `q.w`

We also discovered that #2327 is related to `czm_alphaWeight` and may
be an issue with the weighting function. @bagnell is going to look into it separately.
@mramato mramato mentioned this issue Jan 29, 2015
Merged
@mramato mramato mentioned this issue Mar 5, 2015
Merged
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2017

Is this still an issue?

@mramato
Copy link
Contributor Author

mramato commented Jan 3, 2017

This appears to be OBE and was probably fixes a long time ago.

@mramato mramato closed this as completed Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pjcozzi @emackey @bagnell @mramato