-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM task 'build' is passed a non-Buffer / String variable. #8864
Comments
@TJKoury do you reproduce this just by running |
Tried it in Node 12.16.3, works (type coerced), behavior changed sometime between then and latest. |
Can confirm this bug, running
|
seems like the only thing requiring The majority of references require it to be a boolean, though. it's a simple fix to change this to |
I'd recommend changing it to just writing out a timestamp or something, though I guess that would be a bit redundant. |
We're happy to look at a PR if someone wants to open one. It doesn't really matter that much what gets written out, as long as functionality remains unchanged and it fixes the Node 14 issue. |
The method 'glslToJavaScript' is sometimes passed a Boolean.
Type conversions are not forced in Node 14.x and an exception is thrown. Recommend testing for Boolean and handling accordingly.
The text was updated successfully, but these errors were encountered: