Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Node 14 Gulp Build issue #8897

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

LuminousPath
Copy link
Contributor

@LuminousPath LuminousPath commented Jun 1, 2020

Fixes #8864 by passing the minify argument as a string to fs.writeFileSync

@cesium-concierge
Copy link

Thanks for the pull request @LuminousPath!

  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Jun 3, 2020

Thanks @LuminousPath, even with a small change like this we need a CLA to accept the code. It's up to you if you want to contribute as an individual or on behalf of a company. See Contributor License Agreement for links to the web forms.

If you can't sign a CLA for whatever reason, I'm happy to make this change on your behalf (since it's tiny), but we can't add you to Contributors.md without the CLA. So just let us know either way.

Thanks again.

@LuminousPath
Copy link
Contributor Author

No problem, I had to have a little back-and-forth with my business team but it looks like everything's in order. I've signed the CLA for my company, Navagis, so I think I should be good to go now.

@OmarShehata
Copy link
Contributor

Thanks @LuminousPath ! Can confirm we've received your corporate CLA.

@mramato
Copy link
Contributor

mramato commented Jun 8, 2020

Thanks @LuminousPath!

@mramato mramato merged commit e951c03 into CesiumGS:master Jun 8, 2020
@LuminousPath LuminousPath deleted the gulp_node14_fix branch June 9, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM task 'build' is passed a non-Buffer / String variable.
4 participants