Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer.ConstructorOptions has incomplete JSDoc/TypeScript definitions #9046

Closed
benjaminabb opened this issue Jul 21, 2020 · 3 comments · Fixed by #9063
Closed

Viewer.ConstructorOptions has incomplete JSDoc/TypeScript definitions #9046

benjaminabb opened this issue Jul 21, 2020 · 3 comments · Fixed by #9063
Labels
category - typescript

Comments

@benjaminabb
Copy link
Contributor

In JSDoc property globe is only typed Globe but should be Globe | false

This is only defined in the description

The globe to use in the scene. If set to false, no globe will be added.

Therefore the TypeScript definition is wrong.
@benjaminabb
Copy link
Contributor Author

Also in EasingFunction QUADRACTIC_IN is probably a typo. Same for out and in_out.

@OmarShehata
Copy link
Contributor

Thanks for reporting these @konashredbiker ! Feel free to open a PR to fix these if you'd like, see the contributing guide here: https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#opening-a-pull-request

@benjaminabb benjaminabb mentioned this issue Jul 27, 2020
Merged
@OmarShehata
Copy link
Contributor

I opened a separate issue for the EasingFunction #9220 since the globe type is fixed in #9063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed JSDoc definition and EasingFunction typo benjaminabb/cesium
2 participants
@OmarShehata @benjaminabb