Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Quadractic" typo in EasingFunction #9220

Closed
OmarShehata opened this issue Nov 1, 2020 · 1 comment
Closed

Fix "Quadractic" typo in EasingFunction #9220

OmarShehata opened this issue Nov 1, 2020 · 1 comment
Labels
cleanup good first issue An opportunity for first time contributors

Comments

@OmarShehata
Copy link
Contributor

A PR for this was initially opened here but the change was rolled back since it required a few more changes outside the scope of the PR (#9063 (comment)).

I believe this is all the changes required:

  • In EasingFunction.js, change QUADRACTIC_IN, QUADRACTIC_OUT, QUADRACTIC_IN_OUT to the correct spelling
  • Update the spec in TweenCollectionSpec.js to use the new enums
  • Since this a breaking change, add an additional option in EasingFunction.js with the old spelling to allow for a deprecation period?
  • Throw a deprecationWarning anywhere that takes an EasingFunction to detect the old spelling ? Or perhaps just as a getter on EasingFunction ?
@OmarShehata OmarShehata added cleanup good first issue An opportunity for first time contributors labels Nov 1, 2020
@OmarShehata OmarShehata mentioned this issue Nov 1, 2020
Closed
@nithinp7 nithinp7 mentioned this issue Dec 4, 2020
Merged
@lilleyse
Copy link
Contributor

lilleyse commented Dec 7, 2020

Fixed in #9264

@lilleyse lilleyse closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lilleyse @OmarShehata