Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xdescribe from Vector3DTileContentSpec #10133

Closed
wants to merge 2 commits into from
Closed

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Feb 23, 2022

This xdescribe was from this comment in #7249. I ran Travis three times on this branch and all three builds passed; there will be a fourth run for the second commit. If that passes too this should be safe to merge to main.

I don't want to use the "fixes" keyword since #7249 has more than this test failure but that issue can probably be closed after this is merged.

@ggetz Could you please review/merge once CI passes? Thanks!

@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@mramato
Copy link
Contributor

mramato commented Feb 23, 2022

@ebogo1 did you run these tests locally? Because they still fail for me every time. travis does not run with a real WebGL context, so I'm curious if they pass for anyone else.

@ebogo1
Copy link
Contributor Author

ebogo1 commented Feb 24, 2022

@mramato I definitely thought I did but I can't get them to pass so maybe not. I'll close the PR since there's more digging to do here.

@ebogo1 ebogo1 closed this Feb 24, 2022
@ebogo1 ebogo1 deleted the vector-specs-test branch February 24, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants