Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Cesium3DTilePass #11525

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix typo in Cesium3DTilePass #11525

merged 3 commits into from
Sep 20, 2023

Conversation

jjhembd
Copy link
Contributor

@jjhembd jjhembd commented Sep 18, 2023

Fixes #11516. There was a copy-paste error in Cesium3DTilePass from #11167 which affected the PRELOAD pass.

@cesium-concierge
Copy link

Thanks for the pull request @jjhembd!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@jjhembd jjhembd requested a review from ggetz September 18, 2023 17:34
@ggetz
Copy link
Contributor

ggetz commented Sep 18, 2023

Awesome, thanks @jjhembd! Please update CHANGES.md with a summary of the fix.

@jjhembd
Copy link
Contributor Author

jjhembd commented Sep 20, 2023

@ggetz updated!

@ggetz
Copy link
Contributor

ggetz commented Sep 20, 2023

Thanks @jjhembd! CI is failing due to an unrelated travis error, so I'm going to go ahead and merge.

@ggetz ggetz merged commit 132867c into main Sep 20, 2023
@ggetz ggetz deleted the pass-options-fix branch September 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe a bug in Cesium3DTilePass.js
3 participants