Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outline color in sandcastle to valid value #11701

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Dec 16, 2023

Nine years ago, someone created the "Cylinders and Cones" Sandcastle. The cylinder used the outlineColor: Cesium.Color.DARK_GREEN ever since. Now... this color does not exist. It is called DARKGREEN. Even the screenshot was updated to reflect the actual color that is used there, namely black.

So I'm not even sure whether it should be dark green, or rather black. But I'm just throwing this out here...

Edited:

The name of the cylinder is

name: "Green cylinder with black outline",

so ... I told the sandcastle to 'paint it BLACK' now...

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jjspace jjspace merged commit 187c98b into main Dec 18, 2023
5 checks passed
@jjspace jjspace deleted the fix-sandcastle-outline-color branch December 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants