Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs in VerticalExaggerationPipelineStage #11969

Merged
merged 1 commit into from
May 7, 2024
+4 −6
Merged

Fix docs in VerticalExaggerationPipelineStage #11969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/engine/Source/Scene/Model/VerticalExaggerationPipelineStage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ import ShaderDestination from "../../Renderer/ShaderDestination.js";
import VerticalExaggerationStageVS from "../../Shaders/Model/VerticalExaggerationStageVS.js";

/**
* The custom shader pipeline stage takes GLSL callbacks from the
* {@link CustomShader} and inserts them into the overall shader code for the
* {@link Model}. The input to the callback is a struct with many
* properties that depend on the attributes of the primitive. This shader code
* is automatically generated by this stage.
* The vertical exaggeration pipeline stage transforms the vertex
* positions based on the values of {@link Scene#verticalExaggeration} and
* {@link Scene#verticalExaggerationRelativeHeight}
*
* @namespace VerticalExaggerationPipelineStage
*
Expand All @@ -20,7 +18,7 @@ const VerticalExaggerationPipelineStage = {
const scratchExaggerationUniform = new Cartesian2();

/**
* Add vertical exaggeration to a shader
* Add defines and uniforms for vertical exaggeration calculations in the vertex shader
*
* @param {PrimitiveRenderResources} renderResources The render resources for the primitive
* @param {ModelComponents.Primitive} primitive The primitive to be rendered
Expand Down