Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandcastle contributors guide link #12341

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix sandcastle contributors guide link #12341

merged 1 commit into from
Nov 27, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Nov 26, 2024

Description

This is a very small edgecase scenario that happens when someone tries to open a sandcastle html file directly instead of using the local server. The page it was trying to direct to is on the Wiki we don't really use anymore and instead tried to create a page (if you have access) or redirects to the home page instead of the info you need.
There was one other instance of this check that did have a valid link so this just updates it to match that one

window.location =
"https://github.com/CesiumGS/cesium/blob/main/Documentation/Contributors/BuildGuide/README.md#quickstart";

Issue number and link

No issue

Testing plan

  • Open the Sandcastle gallery in your file explorer
  • Open any html file directly
  • You should see an alert about using the local server and when clicking OK it should redirect you to the contributor docs.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@lukemckinstry
Copy link
Contributor

lukemckinstry commented Nov 26, 2024

What do you mean by this step?

Open any html file directly

@jjspace
Copy link
Contributor Author

jjspace commented Nov 26, 2024

Open the file directly, like double click it and open in a browser not loading it from the localhost server

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I see when I load one of the HTMLs from Windows File Explorer:
image

If I click on "OK" then it takes me here:
image

Looks good to me!

@jjhembd jjhembd added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 78e24ca Nov 27, 2024
10 checks passed
@jjhembd jjhembd deleted the fix-sandcastle-link branch November 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants