Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AEC Sandcastle asset ID's and add AO #12348

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

r-veenstra
Copy link
Contributor

Description

Update new AEC samples with:

  • new asset ID's
  • ambient occlusion

Issue number and link

N/A

Testing plan

  1. Ensure all new asset ID's load correctly
  2. Ensure AO is visible and doesn't substantially impact performance

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Dec 1, 2024

Thank you for the pull request, @r-veenstra! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@r-veenstra r-veenstra marked this pull request as draft December 1, 2024 06:18
@r-veenstra r-veenstra marked this pull request as ready for review December 1, 2024 11:50
@jjhembd
Copy link
Contributor

jjhembd commented Dec 2, 2024

@r-veenstra and @jjspace,
The Ambient Occlusion parameters have changed after #12316. I updated the Sandcastles to reflect the change. This also changes the result--I put a few screenshots below.

No AO:
image

With old AO:
image

With new AO:
image

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjhembd! I think the new ao values look pretty nice. We can adjust them again in the future if we need to for any performance hits but I think these look good for now

@jjspace jjspace added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit dbaf96a Dec 2, 2024
9 checks passed
@jjspace jjspace deleted the aeco-sample-update branch December 2, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants