Mouse up/move events #2408
Merged
Mouse up/move events #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the document from the ScreenSpaceCameraController to the CameraEventAggregator.
Conflicts: CHANGES.md
| @@ -14,6 +14,7 @@ Change Log | |||
| * `Camera.setPositionCartographic` was deprecated in Cesium 1.6. It will be removed in Cesium 1.7. Use `Camera.setView`. | |||
| * `PolygonGraphics.positions` was deprecated and replaced with `PolygonGraphics.hierarchy`, whose value is a `PolygonHierarchy` instead of an array of positions. `PolygonGraphics.positions` will be removed in Cesium 1.8. | |||
| * The `Model.readyToRender` event was deprecated and will be removed in Cesium 1.9. Use the new `Model.readyPromise` instead. | |||
| * The `mouseMoveOnDocument` parameter to the `ScreenSpaceEventHandler` constructor was deprecated in Cesium 1.6. It will be removed in Cesium 1.7. `ScreenSpaceEventHandler` will be constructed as if `mouseMoveOnDocument` is `false`. | |||
There was a problem hiding this comment.
Also, is there anything else we want to say in CHANGE.md?
There was a problem hiding this comment.
Not that I can think of. Did you have something in mind?
|
Doesn't this reintroduce the Sandcastle issue where the globe stops spinning when the mouse moves outside the canvas (as opposed to when Cesium takes up the entire document)? |
|
That has always been the case. You can try it in the Sandcastle in master. I thought we had an issue for it, but I couldn't find it. |
|
Yes, indeed. |
bagnell
added a commit
that referenced
this pull request
Jan 29, 2015
…entHandler to listen on the document for pointer up and move events.
Merged
bagnell
added a commit
that referenced
this pull request
Jan 29, 2015
…entHandler to listen on the document for pointer up and move events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates logic in
ScreenSpaceEventHandlerto add mouse/pointer/touch move and up event listeners to the document instead of the given element. Adds it toCameraEventAggregator.