Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2D picking but not tested with Terrain #2492

Closed
wants to merge 3 commits into from

Conversation

tlpinney
Copy link

No description provided.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 13, 2015

Thanks @tlpinney. @bagnell can you review? @tlpinney was at the OSGeo code sprint with us.

@tlpinney just a heads up that this is failing JSHint:

[runJsHint] Source/Scene/ImageryLayerCollection.js: line 368, col 24, Expected '===' and instead saw '=='.
[runJsHint] Source/Scene/ImageryLayerCollection.js: line 372, col 32, 'pickedPosition' is already defined.
[runJsHint] Source/Scene/ImageryLayerCollection.js: line 374, col 22, 'pickedPosition' used out of scope.
[runJsHint] Source/Scene/ImageryLayerCollection.js: line 378, col 76, 'pickedPosition' used out of scope.

@tlpinney
Copy link
Author

@pjcozzi Thanks. Taking a look now.

@mramato
Copy link
Contributor

mramato commented Oct 13, 2015

Thanks for the pull @tlpinney, but we're doing some PR maintenance and closing this since it's been open forever. I think the real problem is that globe.pick doesn't work in 2D. Your fix works around the imagery picking issue, but doesn't fix the underlying problem. Feel free to re-open this if you want to continue work. Thanks again.

@mramato mramato closed this Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants