Updates to CZML for model node animations #3003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gular property so that it adheres to any interval specified in the model packet.
…ditional transformations from czml
| @@ -235,9 +269,7 @@ define([ | |||
| } | |||
|
|
|||
| function onModelReady(model) { | |||
| model.activeAnimations.addAll({ | |||
There was a problem hiding this comment.
This removes turning on all model animations when the model is loaded. Still need to find a way to manually turn on animations when loading models through the entity framework so the Sandcastle models example works as it did before
There was a problem hiding this comment.
Commit 9359a01 fixes this issue by providing a runAnimations property on ModelGraphics
…to specify if glTF animations should be started
|
related czml-writer PRs. AnalyticalGraphicsInc/czml-writer#101 and AnalyticalGraphicsInc/czml-writer#102 I made additional changes on top of Greg's changes and so I will be opening a new PR to reflect those changes in Cesium as well that will supersede this PR. FYI. |
|
replaced by #3316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.