Improved test coverage #31
Conversation
TextureAtlasSpec UniformDatatype
OrthographicFrustum, and PerspectiveFrustum.
Fixed a faulty test in CompositePrimitiveSpec.
toBeFalsy() with toEqual(false).
PolygonPipeline TextureAtlas Camera2DController CameraColumbusViewController CameraControllerCollection CameraEventHandler CameraFreeLookController Camera Polyline
…unning and added the related test.
Conflicts: Specs/Core/AxisAlignedBoundingBoxSpec.js Specs/Core/AxisAlignedBoundingRectangleSpec.js Specs/Core/BoundingSphereSpec.js Specs/Core/Cartesian3Spec.js Specs/Core/Cartesian4Spec.js Specs/Core/EllipsoidSpec.js Specs/Core/Matrix2Spec.js Specs/Core/Matrix3Spec.js Specs/Core/Matrix4Spec.js Specs/Core/PolygonPipelineSpec.js Specs/Core/QuaternionSpec.js Specs/Core/SunPositionSpec.js Specs/Core/TransformsSpec.js Specs/Core/pointInsideTriangle2DSpec.js Specs/Scene/BillboardCollectionSpec.js Specs/Scene/CameraSpindleControllerSpec.js Specs/Scene/LabelCollectionSpec.js Merged test coverage changes with immutable property changes.
| @@ -0,0 +1,79 @@ | |||
| defineSuite([ | |||
| 'Renderer/UniformDataType' | |||
There was a problem hiding this comment.
This causes require.js to fail when I try to run the tests. It should be 'Renderer/UniformDatatype'.
There was a problem hiding this comment.
Oops. Fixed this in the latest commit.
|
@bagnell Did you look at all the camera tests? Are you happy with them? |
|
Looks good overall. I'll merge this pending my minor comments and any additional ones from @bagnell. |
|
Also, does this include all the test coverage changes that were accidentally included in pull request #23? Did you merge those changes into this branch? |
|
Yes, all those changes are included. |
|
I have looked at the camera tests and they look good to me. |
Conflicts: CHANGES.md Specs/Scene/Texture2DPoolSpec.js
Removed try/catch statements from afterEach when destroy() is called.
|
@kristiancalhoun Let's just clean up the tipsify logic, and then I'll merge this. 84 to 88% code coverage is pretty good. We'll go beyond 90% as we flush out and test streaming imagery. |
Fix missing module require in SensorVolumePortionToDisplay
Update Cesium to 1.32
Update Cesium master to latest from AnalyticalGraphics
Improved test coverage for a variety of types.
Replaced all applicable instances of toBeTruthy() with the stricter toEqual(true) and did likewise for toBeFalsy().