Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointPrimitiveCollection on terrain #3926

Closed
wants to merge 2 commits into from
Closed

PointPrimitiveCollection on terrain #3926

wants to merge 2 commits into from

Conversation

tfili
Copy link
Contributor

@tfili tfili commented May 17, 2016

Suffers from #3921 just like billboards do mainly because the code to implement this is almost identical.

Before this is merged we need to figure out how to fix the clipping. For billboards we force bottom vertical alignment. Maybe we can do the same here.

@mramato
Copy link
Contributor

mramato commented May 17, 2016

After some offline discussion, there is concern that clamping points is not a common enough operation to warrant the overhead this code would add to all points. Since the goal here is supporting clamping of Entity points, @tfili is going to look into doing that at the PointVisualizer level by using clamped billboards in those cases.

We can leave this open until that PR is ready, just in case we decide to go back to this.

@mramato
Copy link
Contributor

mramato commented Jun 23, 2016

Superseded by #3903.

I won't delete the branch right away in case we need this for something down the line.

@mramato mramato closed this Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants