Fix models in 2D near the IDL.

[bagnell]

Adds another command to each node (when not scene3DOnly). Updates that command to position it on the opposite side of the map. Adds the command only if the bounding sphere intersects the IDL.

[pjcozzi]

Can we add a this for this? Are you writing tests in this branch or models-2D?

[pjcozzi]

Does picking work for models crossing the IDL?

[pjcozzi]

So picking works across the IDL even though there is only one pick command?

[pjcozzi]

Never mind, I see.

[pjcozzi]

Just those comments.

[bagnell]

Can we add a this for this? Are you writing tests in this branch or models-2D?

I added tests in models-2D so you don't see them in the diff, but I'll add one with a model crossing the IDL here.

[bagnell]

@pjcozzi This is ready for another look. There are some failing tests that were caused by #3933. I'll fix them in the models-2D branch. All of the model tests here should pass though.

[pjcozzi]

Using this code in Sandcastle:

var viewer = new Cesium.Viewer('cesiumContainer', {
    infoBox : false,
    selectionIndicator : false
});

function createModel(url, height) {
    viewer.entities.removeAll();

    var position = Cesium.Cartesian3.fromDegrees(-179.0744619, 44.0503706, height);
    var heading = Cesium.Math.toRadians(135);
    var pitch = 0;
    var roll = 0;
    var orientation = Cesium.Transforms.headingPitchRollQuaternion(position, heading, pitch, roll);

    var entity = viewer.entities.add({
        name : url,
        position : position,
        orientation : orientation,
        model : {
            uri : url,
            minimumPixelSize : 128,
            //maximumScale : 20000
        }
    });
    viewer.trackedEntity = entity;
}

var options = [{
    text : 'Aircraft',
    onselect : function() {
        createModel('../../SampleData/models/CesiumAir/Cesium_Air.glb', 5000.0);
    }
}, {
    text : 'Ground vehicle',
    onselect : function() {
        createModel('../../SampleData/models/CesiumGround/Cesium_Ground.glb', 0);
    }
}, {
    text : 'Milk truck',
    onselect : function() {
        createModel('../../SampleData/models/CesiumMilkTruck/CesiumMilkTruck-kmc.glb', 0);
    }
}, {
    text : 'Skinned character',
    onselect : function() {
        createModel('../../SampleData/models/CesiumMan/Cesium_Man.glb', 0);
    }
}];

Sandcastle.addToolbarMenu(options);

Switch to 2D, zoom in a bit, then pan to the left. The model changes orientation and then Cesium throws an exception (only got the exception once though).

[bagnell]

@pjcozzi This is ready for another look.

[pjcozzi]

JSHint fails in CI:

Source/Scene/Model.js
line 3164 col 9 'scratchCartographic' is already defined.

[pjcozzi]

Just got this again when panning left to right (back and forth a few times) in 2D using the above code.

[bagnell]

@pjcozzi I can reproduce that error consistently now after talking offline. The problem is in master as well. It happens when the camera lines up with the IDL. I'm working on a fix but it doesn't need to hold up this PR.

[pjcozzi]

This is ready since #3953 was merged.