Refresh imagery provider #5536

tfili · 2017-06-26T18:01:28Z

Adds some plumbing that allows for an imagery provider to be reloaded.

Also adds the ability for SingleTileImageryProvider to take an Image or Canvas, along with tests.

…le example.

…vider

tfili · 2017-06-26T19:26:42Z

@bagnell Can you take a look at this an make sure I'm not doing anything inherently bad at the imagery provider layer? I'll probably need to do a little cleanup with the callbacks once you give the ok.

pjcozzi · 2017-06-26T22:10:31Z

@kring any chance you are available to also review this?

pjcozzi

Just trivial comments, I don't have any unique insights here.

pjcozzi · 2017-06-27T20:44:41Z

Apps/Sandcastle/gallery/Refresh Imagery Provider.html

+viewer.imageryLayers.addImageryProvider(videoProvider);
+
+viewer.scene.preRender.addEventListener(function() {
+    videoProvider.reload();


Given that the video element is "dynamic", could this be implicit so the user doesn't need to call it when the input is a video element?

I dunno if it will be common enough and if the lack of symmetry with the less frequent dynamic update does more harm than good to the API. Just, in general, whenever the user needs to "make something dirty", it is error prone as we've also ran into this with 3D Tiles styling.

I think it would be a little weird requiring the the SingleTileImageryProvider to take the scene for this purpose. Not sure how else I would do it.

We could work it into the render loop, but don't worry about it; I doubt it is important enough.

pjcozzi · 2017-06-27T20:47:46Z

Source/Scene/GlobeSurfaceTileProvider.js

+                    }
+
+                    // Insert immediately after existing TileImageries
+                    var insertionPoint = startIndex+tileImageriesToFree;


Whitespace, sorry.

pjcozzi · 2017-06-27T20:50:53Z

Source/Scene/SingleTileImageryProvider.js

+
+        this._url = url;
+        if (defined(url)) {
+            deprecationWarning('SingleTileImageryProvider.url', 'SingleTileImageryProvider url parameter was deprecated in Cesium 1.35. It now takes an image parameter that can contain a url, a Canvas or an Image. It will be removed in Cesium 1.37.');


Update CHANGES.md.

Seems like this should make 1.35.

pjcozzi · 2017-06-27T20:52:08Z

Specs/Scene/SingleTileImageryProviderSpec.js

+        expect(provider._ready).toBe(true);
+    });
+
+    it('reload calls the _reload function', function() {


Seems like we would need more unit tests to cover all the cases in the new code, right?

…vider

pjcozzi · 2017-06-28T23:28:55Z

@bagnell would you be able to do a quick review of this and #5542?

bagnell · 2017-06-29T19:59:49Z

Source/Scene/GlobeSurfaceTileProvider.js

@@ -1,92 +1,92 @@
 /*global define*/
 define([
-        '../Core/BoundingSphere',


Whitespace.

You can run npm run sortRequires to fix this. I would merge master in first.

bagnell · 2017-06-29T20:16:03Z

Zoom in and out for a bit with a tilted view and you'll see this:

bagnell · 2017-06-29T20:21:17Z

If you move colorProvider.reload() to the pre-render event, this can happen:

It should be all green. When you zoom out, the green image is replaced by blue. When you zoom in, all images are green.

bagnell · 2017-06-29T20:29:15Z

Source/Scene/GlobeSurfaceTileProvider.js

@@ -611,11 +611,98 @@ define([
        return destroyObject(this);
    };

+    function getTileReadyCallback(tileImageriesToFree, layer, terrainProvider) {
+        return function(tile) {
+            var tileImagery, imagery;


Declare on two separate lines.

bagnell · 2017-06-29T20:56:29Z

Just, in general, whenever the user needs to "make something dirty", it is error prone as we've also ran into this with 3D Tiles styling.

I agree. Could you add something like a dynamic property? In the render loop, loop over the imagery providers and call _reload when it is dynamic. Can you detect when it is a HTMLVideoElement and default it to true; otherwise, default to false?

cesium-concierge · 2018-12-11T22:00:38Z

Thanks again for your contribution @tfili!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

hpinkos · 2018-12-12T20:24:47Z

@tfili what do we want to do with this PR?

cesium-concierge · 2019-01-12T03:00:18Z

Thanks again for your contribution @tfili!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

tfili · 2019-01-14T21:20:24Z

@hpinkos I don't have time to look at it. A bunch of it was plumbing that was needed for time dynamic WMTS. That has already been merged. What is left is some changes to the interface of SingleTileImageryProvider to take a canvas or image, so it can be used for video. You can close it. There are probably better ways to do it, that we can look at later if need be.

Tom Fili added 8 commits June 8, 2017 15:05

Added logic to reload SingleTileImageryProvider along with a Sandcast…

76efa1b

…le example.

Don't remove imagery until the new imagery is loaded.

8e1c565

Got video actually working.

7a87860

Merge remote-tracking branch 'origin/master' into refresh-imagery-pro…

2ad8207

…vider

Typo.

02e6f23

Merge remote-tracking branch 'origin/master' into refresh-imagery-pro…

dd3b4fd

…vider

Added some tests for new SingleTileImageryProvider options.

6fda810

Added screenshot and fixed sandcastle example.

4a45fe9

tfili mentioned this pull request Jun 27, 2017

WMTS support for time-dynamic and static dimensions #5542

Closed

4 tasks

pjcozzi reviewed Jun 27, 2017

View reviewed changes

Tom Fili added 3 commits June 27, 2017 20:33

Merge remote-tracking branch 'origin/master' into refresh-imagery-pro…

0e87db2

…vider

More tweaks from PR comments.

0e31846

Cleanup.

6e57e94

bagnell reviewed Jun 29, 2017

View reviewed changes

Tom Fili added 2 commits June 29, 2017 17:37

Tweaks from PR comments.

a0d7b06

Cleanup.

95afb2b

tfili closed this Jan 14, 2019

tfili deleted the refresh-imagery-provider branch January 14, 2019 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refresh imagery provider #5536

Refresh imagery provider #5536

tfili commented Jun 26, 2017

tfili commented Jun 26, 2017

pjcozzi commented Jun 26, 2017

pjcozzi left a comment

pjcozzi Jun 27, 2017

tfili Jun 28, 2017

pjcozzi Jun 28, 2017

pjcozzi Jun 27, 2017

pjcozzi Jun 27, 2017

pjcozzi Jun 27, 2017

pjcozzi commented Jun 28, 2017

bagnell Jun 29, 2017

bagnell Jun 29, 2017

bagnell commented Jun 29, 2017

bagnell commented Jun 29, 2017

bagnell Jun 29, 2017

bagnell commented Jun 29, 2017

cesium-concierge commented Dec 11, 2018

hpinkos commented Dec 12, 2018

cesium-concierge commented Jan 12, 2019

tfili commented Jan 14, 2019 •

edited

Loading

Refresh imagery provider #5536

Refresh imagery provider #5536

Conversation

tfili commented Jun 26, 2017

tfili commented Jun 26, 2017

pjcozzi commented Jun 26, 2017

pjcozzi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Jun 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bagnell commented Jun 29, 2017

bagnell commented Jun 29, 2017

Choose a reason for hiding this comment

bagnell commented Jun 29, 2017

cesium-concierge commented Dec 11, 2018

hpinkos commented Dec 12, 2018

cesium-concierge commented Jan 12, 2019

tfili commented Jan 14, 2019 • edited Loading

tfili commented Jan 14, 2019 •

edited

Loading