Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultValue check for null #5551

Merged
merged 6 commits into from
Jun 28, 2017
Merged

defaultValue check for null #5551

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1c80a2
defaultValue check for null
Rudraksha20 Jun 28, 2017
e674762
Updated CHANGES.md
Rudraksha20 Jun 28, 2017
8776c8c
Spell Checked CHANGES.md, sorry
Rudraksha20 Jun 28, 2017
66cbb87
Added Unit Test for defaultValue.js
Rudraksha20 Jun 28, 2017
02a97c5
Updated defaultValueSpec.js
Rudraksha20 Jun 28, 2017
96e75ad
Update CHANGES.md
Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Specs/Core/defaultValueSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*global defineSuite*/
defineSuite([
'Core/defaultValue'
], function(
defaultValue) {
'use strict';

it('Works with first parameter undefined', function() {
expect(function(){
defaultValue.defaultValue(undefined, 5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just become expect(defaultValue(undefined,5).toEqual(5), I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omh1280 yup, updated with the changes.

}).toEqual(5);
});

it('Works with first parameter null', function() {
expect(function(){
defaultValue.defaultValue(null, 5);
}).toEqual(5);
});

it('Works with first parameter not undefined and not null', function() {
expect(function(){
defaultValue.defaultValue(1, 5);
}).toEqual(1);
});

});