fix clipping planes bug with 3d tilesets #6486
Conversation
|
@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time. I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Source/Scene/Cesium3DTile.js
Outdated
| @@ -733,6 +733,8 @@ define([ | |||
| this.replacementNode = undefined; | |||
|
|
|||
| this.lastStyleTime = 0; | |||
| this.clippingPlanesDirty = this._clippingPlanesState === 0; | |||
There was a problem hiding this comment.
We don't chain values like this, but since you're already setting this._clippingPlanesState on the next line, I assume this is a copy/paste error.
There was a problem hiding this comment.
This isn't chaining values. It's setting clippingPlanesDirty to a boolean if _clippingPlanesState is equal to 0
There was a problem hiding this comment.
Ahh, I missed that. Still this line is confusing, perhaps put the right hand side in parenthesis to make it more obvious.
|
Thanks @likangning93, this fixes it. |
Fixes #6484