Geometry offset attribute cleanup #6742
Merged
+42
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup from #6607
offsetAttribute
through to the geometry instead of searching through theapplyOffset
per vertex to figure out if the geometry was usingGeometryOffsetAttribute.TOP
GeometryOffsetAttribute.NONE
undefined
attributes : { color : colorAttribute, offset : undefined }
instead ofattributes : {color : colorAttribute}