Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry offset attribute cleanup #6742

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Geometry offset attribute cleanup #6742

merged 2 commits into from
Jun 27, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jun 27, 2018

Cleanup from #6607

  • Fix IE by passing the offsetAttribute through to the geometry instead of searching through the applyOffset per vertex to figure out if the geometry was using GeometryOffsetAttribute.TOP
  • Fix bounding sphere when using GeometryOffsetAttribute.NONE
  • Fix bounding sphere when retrieving it from the geometry instance batch table
  • Fix crash if instance attribute was undefined
    • ie. attributes : { color : colorAttribute, offset : undefined } instead of attributes : {color : colorAttribute}

@mramato
Copy link
Contributor

mramato commented Jun 27, 2018

@bagnell can you take a look at this?

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 27, 2018

One sec, I fixed this for synchornous primitives but not asynchronous

@hpinkos hpinkos force-pushed the fix-ie-offset-geometry branch from a0d733d to 157cb6d Compare June 27, 2018 21:30
@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 27, 2018

@bagnell this is ready for a full review now. Thanks!

Copy link
Contributor

@bagnell bagnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bagnell bagnell merged commit 4c04d17 into master Jun 27, 2018
@bagnell bagnell deleted the fix-ie-offset-geometry branch June 27, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants