Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset attribute to box, cylinder and ellipsoid #6931

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 17, 2018

For #6777

Adds offsetAttribute support to BoxGeometry, CylinderGeometry and EllipsoidGeometry

No need to update CHANGES from this because the attribute is private. It will be hooked up to the Entity API level for adding heightReference support to these types

@hpinkos hpinkos requested a review from bagnell August 17, 2018 16:32
@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Aug 17, 2018

Looks good. d6c23ee just has spacing changes.

@bagnell bagnell merged commit c3cb517 into master Aug 17, 2018
@bagnell bagnell deleted the geometry-height-reference branch August 17, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants