-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix polyline clipping against the near plane. #7209
Conversation
Thanks for the pull request @bagnell!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
@bagnell This seems to fix the camera angle posted in that issue, but I'm still seeing some weirdness from different angles. |
Thanks @hpinkos. It's fixed. This seems like it should have been a bug for a while, but I couldn't find any issue for it. |
@bagnell looks fine in chrome now. It's doing something weird in IE though. That doesn't happen in master. It happens in this branch with var viewer = new Cesium.Viewer('cesiumContainer');
var scene = viewer.scene;
scene.logarithmicDepthBuffer = false;
var blueCartographic = new Cesium.Cartographic(-1.3196863177294136, 0.6988508714746624, 30.0);
var redCartographic = new Cesium.Cartographic(-1.319681841889412, 0.6989153500784591, 30.0);
var arrowPositions = [
Cesium.Cartographic.toCartesian(blueCartographic),
Cesium.Cartographic.toCartesian(redCartographic)
];
var line = viewer.entities.add({
polyline : {
positions : arrowPositions,
width : 50,
followSurface : false,
material : new Cesium.PolylineArrowMaterialProperty(Cesium.Color.CYAN)
}
});
viewer.zoomTo(viewer.entities); |
@hpinkos this is ready for another look. |
Looks great, thanks @bagnell! |
Fixes the issue from this comment: #6741 (comment)