Fix Resource template replacement. #7668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @shunter!
Reviewers, don't forget to make sure that:
|
shunter
force-pushed
the
fixResourceTemplating
branch
2 times, most recently
from
8be93e4 to
a485b5b
Compare
The previous implementation did not work with template keys that are numbers, because the regex syntax was not escaped properly. Instead of building a regex for each replacement, we can use a replace callback method.
shunter
force-pushed
the
fixResourceTemplating
branch
from
a485b5b to
fb82376
Compare
emackey
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation did not work with template keys that are numbers, because the regex syntax was not escaped properly when building a regex from a string.
Instead of building a separate regex for each replacement, we can simply run a single replace with a callback method.
This fixes the ability to construct
Iau2006XysDatawith axysFileUrlTemplate, which was a regression since #6035.