Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7621
Resolves the promise of
clampToHeightMostDetailed
andsampleHeightMostDetailed
during thepostRender
event to ensure that entities are never created mid-frame, which is anywhere betweenviewer._onTick
andviewer._postRender
.The order of events in a single render loop is basically:
viewer._onTick
updateAsyncRayPicks
(inscene.render
) (this is renamed toupdateMostDetailedRayPicks
in @loshjawrence's branch)2.a. Synchronous pick calls immediately when the async ray is ready
viewer._postRender
(first subscriber toscene.postRender
)scene.postRender
including these new events.