empty objects in options have been replaced

[abu271]

This pull request solves issue 7588. The object literals in options = defaultValue(options, {}); have been replaced with defaultValue.EMPTY_OBJECT.

The CONTRIBUTORS.md file has been updated with my information.

[cesium-concierge]

Thanks for the pull request @abuDarda97!

• ❌ Missing CLA.
  • Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[abu271]

Individual CLA text file has been sent.

[pjcozzi]

Thanks again for contributing, @abuDarda97, we received your CLA.

[abu271]

@pjcozzi you're welcome, I am glad that I can help.

[shunter]

Just the one error to correct.

[shunter]

This change is incorrect because the line below modifies options.

[abu271]

So, I should change it back to options = defaultValue(options, {}); ?

[emackey]

I believe so, yes. Please also put a comment pointing out that options is being modified, which explains why we can't use EMPTY_OBJECT here.

[abu271]

Hi @shunter @emackey I have made the changes, is there anything else I need to change?

[cesium-concierge]

Thanks again for your contribution @abuDarda97!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[abu271]

@OmarShehata

[cesium-concierge]

Thanks again for your contribution @abuDarda97!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[OmarShehata]

Thanks for the review @shunter and @emackey ! This looks good to me, and can confirm all tests are running locally.

Thanks again @abuDarda97 !