Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarifying doc about node transformation #7886

Merged
merged 2 commits into from
May 31, 2019
Merged

Add clarifying doc about node transformation #7886

merged 2 commits into from
May 31, 2019

Conversation

lilleyse
Copy link
Contributor

For #7615

@lilleyse lilleyse requested a review from OmarShehata May 31, 2019 13:05
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@emackey emackey merged commit ba7fbc9 into master May 31, 2019
@emackey emackey deleted the node-transforms-doc branch May 31, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

@OmarShehata OmarShehata Awaiting requested review from OmarShehata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilleyse @cesium-concierge @emackey