Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: PerInstanceColorAppearance vertex format and other primitive API stuff #7947

Merged
merged 8 commits into from
Sep 18, 2019
Merged

Update docs: PerInstanceColorAppearance vertex format and other primitive API stuff #7947

merged 8 commits into from
Sep 18, 2019

Conversation

nmschulte-aviture
Copy link
Contributor

@nmschulte-aviture nmschulte-aviture commented Jun 18, 2019

I believe FLAT_VERTEX_FORMAT's documentation is supposed to read "when true", not "false".


As well, the documentation for VERTEX_FORMAT mis-matches the code; I've included a documentation change to make them match.

See also #8045; a bug moved from this PR.


CLA is signed and CONTRIBUTORS.md is already updated:
https://github.com/Aviture/cesium/blame/fix-perinstancecolorappearance-doc/CONTRIBUTORS.md#L69

@cesium-concierge
Copy link

Thank you so much for the pull request @nmschulte-aviture! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@nmschulte-aviture nmschulte-aviture changed the title FLAT_VERTEX_FORMAT doc: s/false/true/ Update PerInstanceColorAppearance vertex format documentation Jun 18, 2019
@nmschulte-aviture nmschulte-aviture changed the title Update PerInstanceColorAppearance vertex format documentation Update docs: PerInstanceColorAppearance vertex format and other primitive API stuff Jun 19, 2019
@cesium-concierge
Copy link

Thanks again for your contribution @nmschulte-aviture!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @nmschulte-aviture!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Thanks @nmschulte-aviture!

@hpinkos hpinkos merged commit 339fd2f into CesiumGS:master Sep 18, 2019
@cesium-concierge
Copy link

Thanks for the awesome work @nmschulte-aviture! Your contribution is about to launch to millions of users with the next release. 🚀

Do you mind if we tweet about it? CC @OmarShehata @slchow.

@nmschulte-aviture nmschulte-aviture deleted the fix-perinstancecolorappearance-doc branch November 8, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants