-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs: PerInstanceColorAppearance
vertex format and other primitive API stuff
#7947
Update docs: PerInstanceColorAppearance
vertex format and other primitive API stuff
#7947
Conversation
Thank you so much for the pull request @nmschulte-aviture! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
|
s/false/true/
PerInstanceColorAppearance
vertex format documentation
PerInstanceColorAppearance
vertex format documentationPerInstanceColorAppearance
vertex format and other primitive API stuff
Thanks again for your contribution @nmschulte-aviture! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte-aviture! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks @nmschulte-aviture! |
Thanks for the awesome work @nmschulte-aviture! Your contribution is about to launch to millions of users with the next release. 🚀 Do you mind if we tweet about it? CC @OmarShehata @slchow. |
I believe
FLAT_VERTEX_FORMAT
's documentation is supposed to read "whentrue
", not "false
".As well, the documentation for
VERTEX_FORMAT
mis-matches the code; I've included a documentation change to make them match.See also #8045; a bug moved from this PR.
CLA is signed and
CONTRIBUTORS.md
is already updated:https://github.com/Aviture/cesium/blame/fix-perinstancecolorappearance-doc/CONTRIBUTORS.md#L69