Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spelling Error #8036

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Fix Spelling Error #8036

merged 4 commits into from
Sep 5, 2019

Conversation

TJKoury
Copy link
Contributor

@TJKoury TJKoury commented Aug 3, 2019

_removeDefaultDataSoureListener - > _removeDefaultDataSourceListener

_removeDefaultDataSoureListener - > _removeDefaultDataSourceListener
@cesium-concierge
Copy link

Thank you so much for the pull request @TJKoury! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 5, 2019

Thanks @TJKoury! If you search for Soure, the same spelling mistake is in a few other places in that file. Can you fix that too please?

@TJKoury
Copy link
Contributor Author

TJKoury commented Aug 5, 2019

@hpinkos Good catch! Done.

@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 5, 2019

whoops, sorry for the delay on this @TJKoury! I'll get this merged as soon as CI passes

@TJKoury
Copy link
Contributor Author

TJKoury commented Sep 5, 2019

You are doing me the favor, @hpinkos! Thanks for the update.

@hpinkos hpinkos merged commit e28ce86 into CesiumGS:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants