Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parent tilesets's tilesetVersion if it's set and none on the child. #8108

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 26, 2019

If a parent contains a tilesetVersion parameter, then child tilesets should use it if they do not have a tilesetVersion of their own.

This fixes this demo where you can see it was dropping the v parameter for some tiles when you zoomed in.

@lilleyse are there any spec implications here? I couldn't find anything in the spec regarding tilesetVersion and external/child tilesets but perhaps it's an implementation guidelines instead of not in the spec itself?

If a parent contains a `tilesetVersion` parameter, then child tilesets
should use it if they do not have a `tilesetVersion` of their own.
@mramato mramato requested a review from lilleyse August 26, 2019 19:00
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Looks good.

@lilleyse are there any spec implications here? I couldn't find anything in the spec regarding tilesetVersion and external/child tilesets but perhaps it's an implementation guidelines instead of not in the spec itself?

The wording isn't very clear about that. I'll open an issue. But this change seems more spec compliant since an external tileset is still part of the root tileset.

@lilleyse lilleyse merged commit b0c49bf into master Aug 26, 2019
@lilleyse lilleyse deleted the tileset-version branch August 26, 2019 19:29
@lilleyse
Copy link
Contributor

Opened CesiumGS/3d-tiles#381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants