Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added high dynamic range (HDR) sandcastle example #8147

Merged
merged 4 commits into from
Sep 11, 2019
Merged

Conversation

IanLilleyT
Copy link
Contributor

@IanLilleyT IanLilleyT commented Sep 10, 2019

For #8102

Added a toggle for HDR in sandcastle. Includes a dazzling view of the grand canyon and a milk truck.

@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Can you rename the example to High Dynamic Range?

@IanLilleyT IanLilleyT changed the title added hdr toggle sandcastle example Added high dynamic range (HDR) sandcastle example Sep 10, 2019
@lilleyse
Copy link
Contributor

@IanLilleyT there are some eslint errors that caused CI to fail.

@lilleyse
Copy link
Contributor

Looks good, thanks @IanLilleyT

@lilleyse lilleyse merged commit 3ff84bd into master Sep 11, 2019
@lilleyse lilleyse deleted the fxaa-sandcastle branch September 11, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants