Fix OIT texture not clearing properly #8312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug @likangning93 noticed where OIT textures would not get cleared correctly because of changes in #8205. No CHANGES.md entry required since this change has not been shipped yet.
Previously
GlobeDepth
would recreate its textures whenclearGlobeDepth
changed in order to create the primitive framebuffer. This also recreated the main framebuffer, which was fine, but OIT did not have the proper checks to notice that the framebuffer had changed. I considered adding aclearGlodeDepth
check inOIT
but decided to just separate primitive framebuffer creation and main frambuffer creation inGlobeDepth
.Sandcastle with GeoJSON from http://data.phl.opendata.arcgis.com/datasets/f43e5f92d34e41249e7a11f269792d11_0.geojson. Select CWT from the base layer dropdown to see the bug.