Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIT texture not clearing properly #8312

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Oct 22, 2019

Fixes a bug @likangning93 noticed where OIT textures would not get cleared correctly because of changes in #8205. No CHANGES.md entry required since this change has not been shipped yet.

Previously GlobeDepth would recreate its textures when clearGlobeDepth changed in order to create the primitive framebuffer. This also recreated the main framebuffer, which was fine, but OIT did not have the proper checks to notice that the framebuffer had changed. I considered adding a clearGlodeDepth check in OIT but decided to just separate primitive framebuffer creation and main frambuffer creation in GlobeDepth.

Sandcastle with GeoJSON from http://data.phl.opendata.arcgis.com/datasets/f43e5f92d34e41249e7a11f269792d11_0.geojson. Select CWT from the base layer dropdown to see the bug.

oit-bug

@lilleyse lilleyse requested a review from likangning93 October 22, 2019 16:43
@cesium-concierge
Copy link

cesium-concierge commented Oct 22, 2019

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@likangning93
Copy link
Contributor

Thanks @lilleyse, works as advertised!

@likangning93 likangning93 merged commit 67b1130 into master Oct 23, 2019
@likangning93 likangning93 deleted the clear-globe-depth-translucency-fix branch October 23, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants