Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knockout to 3.5.1 #8424

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Update knockout to 3.5.1 #8424

merged 1 commit into from
Feb 26, 2020

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Nov 30, 2019

This is just a maintenance update with no changes required on our end.

@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • ❔ Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor Author

mramato commented Nov 30, 2019

Node seems to be having an issue, I'll bump when ready.

@cesium-concierge
Copy link

Thanks again for your contribution @mramato!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 29, 2020

Thanks @mramato, this change looks good to me. There was a weird CI failure so I just restarted it to see if it was an actual problem

@hpinkos
Copy link
Contributor

hpinkos commented Jan 29, 2020

@mramato yeah, can you look at the CI failure here?

This is just a maintenance update with no changes required on our end
other than patching knockout to work with our build system.
@mramato
Copy link
Contributor Author

mramato commented Feb 26, 2020

@hpinkos only took 4 weeks, but this is ready 😄

@hpinkos
Copy link
Contributor

hpinkos commented Feb 26, 2020

👍

@hpinkos hpinkos merged commit a63992b into master Feb 26, 2020
@hpinkos hpinkos deleted the update-knockout branch February 26, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants