Greatly improve performance of clamped Entity geometry with dynamic colors #8630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we originally added support for GroundPrimitive, it did not support per-instance colors. We fixed this some time ago but apparently the Entity API or ClassificationPrimitive was never properly updated to take advantage of it.
The below Sandcastle code is unusably slow in master, in this branch is flies.
I have some failing tests that need to be fixed, but I wanted to get the PR open to ensure that there wasn't some other reason this limitation was in place that I missed. Especially my changes to the
ClassificationPrimitive
andPrimitive
. CC @likangning93 @lilleyse