-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point cloud styling fixes #8785
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
e18cb4a
to
7f7c4d7
Compare
Awesome! Thanks for the quick fix @lilleyse! |
@lilleyse It would be good to have tests for handling properties with spaces and Unicode characters |
Added a test and confirmed the test fails in master. @sanjeetsuhag do you have other feedback? |
Would love to see this go into the next release. @sanjeetsuhag is there anything else you're looking for here? |
Code, sandcastle and test look good. Thanks @lilleyse! |
${feature.propertyName}
and${feature['propertyName']}
syntax now works for point clouds using the GLSL styling backend. It was an oversight ingetShaderExpression
and required just a few small changes.The bigger change here is supporting feature properties with non-alphanumeric characters, like
${feature['temperature value 😀']}
. The shader was using the property name as-is which doesn't compile if the name has spaces or unicode characters. Now the shader attribute is named with a unique id.Local sandcastle