Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translucency to outlineColor #9003

Merged
merged 4 commits into from
Jul 20, 2020
Merged

add translucency to outlineColor #9003

merged 4 commits into from
Jul 20, 2020

Conversation

LHolst
Copy link
Contributor

@LHolst LHolst commented Jun 30, 2020

fix for #8553

PR adds translucency to outlineColor in BillboardCollectionVS

@cesium-concierge
Copy link

Thank you so much for the pull request @LHolst! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @LHolst ! Can you please fill out a contributor's license agreement? https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

fix for CesiumGS#8553

PR adds translucency to outlineColor in BillboardCollectionVS
update contributors to include Geoplex GIS GmbH members
@LHolst
Copy link
Contributor Author

LHolst commented Jul 1, 2020

CLA signed and CONTRIBUTORS updated

@hpinkos
Copy link
Contributor

hpinkos commented Jul 9, 2020

Thanks @LHolst! I'll try to review this and get it in before the next release

CONTRIBUTORS.md Outdated Show resolved Hide resolved
@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2020

Looks great @LHolst, thanks! I'll merge this as soon as CI passes

@LHolst
Copy link
Contributor Author

LHolst commented Jul 20, 2020

Thanks @hpinkos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants