Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #1

Closed
48 of 61 tasks
pjcozzi opened this issue Nov 15, 2015 · 10 comments
Closed
48 of 61 tasks

Roadmap #1

pjcozzi opened this issue Nov 15, 2015 · 10 comments
Labels

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 15, 2015

@leerichard42

@pjcozzi

  • Set up command-line tool, tests, jshint, etc.
  • Add third-party licenses to LICENSE.md
  • Set up coverage
  • Set up browserify
  • Stage to add defaults. Replace gltfDefaults in Cesium.
    • Separate glTF 0.8 to 1.0 into another stage
    • Separate materials extension?
  • Stage to generate shaders/techniques/materials from KHR_materials_common. Move modelMaterialsCommon from obj2gltf and Cesium to here.
    • Update obj2gltf and Cesium to use gltf-pipeline via npm and browserify.
  • Streamline use of Cesium npm module, Cesium 2 cesium#2524.
  • Figure out in-memory representation so each stage doesn't have to write to and read from disk
  • Run jasmine and istanbul through gulp and karma
  • Reference doc
  • Publish to npm
  • Consider using ES6 features with Node 4. https://github.com/bevacqua/es6
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Apr 26, 2016

@leerichard42 do you want to finish up the semester by implementing this optimization:

[ ] Stage to remove unused vertices

We can generalize it a bit to remove empty parts of buffers in general.

@leerichard42
Copy link
Contributor

Yes, sounds good! What exactly does it mean for a vertex to be unused/what is an empty part of a buffer? Would this consist of checking the sections of a buffer that are referenced by buffer views, and removing the sections which are not accessed?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Apr 27, 2016

Exactly, I think all we need to do is once the pipeline stages to remove unused buffer views, accessors, etc. are ran, we just look for parts of buffers that are not referenced by buffer views, compact them, then update the buffer views.

@tfili do you have any other advice here?

@tfili
Copy link

tfili commented Apr 27, 2016

You would be surprised how often you end up with vertex data that is never referenced by the indices. It must just be crappy exporters. Although rare, I've seen it where hundreds or thousands of vertices were removed. Normally it is just a few.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Apr 27, 2016

Ah right, good call @tfili! So @leerichard42 you'll have to check all the indices to see what parts of buffer views aren't used as well. If it is cleaner, this could be two separate stages.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 17, 2016

  • Stage to remove duplicate (property-wise) techniques/materials.

Is this done?

@lasalvavida
Copy link
Contributor

#152 will do that, but I'd prefer to get #157 in first.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 17, 2016

OK, no rush. Just curious. Please keep this issue updated as things are merged.

@ggetz
Copy link
Contributor

ggetz commented Jun 25, 2018

@lilleyse @pjcozzi Good to close? Do we want to split any of the remaining items into their won issues?

@lilleyse
Copy link
Contributor

Should be fine to close. Some of the items have been completed and others are probably out of scope now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants