-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap #1
Comments
@leerichard42 do you want to finish up the semester by implementing this optimization:
We can generalize it a bit to remove empty parts of buffers in general. |
Yes, sounds good! What exactly does it mean for a vertex to be unused/what is an empty part of a buffer? Would this consist of checking the sections of a buffer that are referenced by buffer views, and removing the sections which are not accessed? |
Exactly, I think all we need to do is once the pipeline stages to remove unused buffer views, accessors, etc. are ran, we just look for parts of buffers that are not referenced by buffer views, compact them, then update the buffer views. @tfili do you have any other advice here? |
You would be surprised how often you end up with vertex data that is never referenced by the indices. It must just be crappy exporters. Although rare, I've seen it where hundreds or thousands of vertices were removed. Normally it is just a few. |
Ah right, good call @tfili! So @leerichard42 you'll have to check all the indices to see what parts of buffer views aren't used as well. If it is cleaner, this could be two separate stages. |
Is this done? |
OK, no rush. Just curious. Please keep this issue updated as things are merged. |
Should be fine to close. Some of the items have been completed and others are probably out of scope now. |
@leerichard42
accessor
buffer
bufferView
camera
image
material
mesh
node
program
sampler
shader
skin
technique
texture
@pjcozzi
modelMaterialsCommon
from obj2gltf and Cesium to here.The text was updated successfully, but these errors were encountered: